I have been on a trainee position for two years now, when is the right time for the employer / manager to review my title and salary? How long should one be kept on a training position?
That is between you and the employer - unless there is something in your contract to indicate otherwise, there is no obligation on them to promote you or change your title.